MUC Light ODBC #1093

fenek · 2016-11-29T20:13:41Z

This PR adds basic ODBC backend for MUC Light.

It should be a subject of load testing, whether this backend needs optimisation, caching, stored procedures or any other improvements.

gadgetci · 2016-11-29T20:14:05Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+-include("jlib.hrl").
+-include("mod_muc_light.hrl").
+
+-define(esc(T), ejabberd_odbc:escape(T)).


According to Elvis:

Invalid macro name esc on line 62. Use UPPER_CASE.

gadgetci · 2016-11-29T20:14:07Z

apps/ejabberd/src/mod_muc_light.erl

@@ -304,7 +311,7 @@ add_rooms_to_roster(Acc, UserUS) ->
                                      children = [#xmlcdata{ content = RoomVersion }] }]
                       },
              [Item | Acc0]
-      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS)))).
+      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS, undefined)))).

 -spec process_iq_get(Acc :: any(), From :: #jid{}, To :: #jid{},


According to Elvis:

The spec in line 316 uses a record, please define a type for the record and use that instead.

I agree with Elvis here.

gadgetci · 2016-11-29T20:14:09Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+                {selected, _, [{<<"0">>}]} ->
+                    throw({aborted, Reason});
+                {selected, _, [{<<"1">>}]} ->
+                    case NodeCandidate of


According to Elvis:

The expression on line 316 and column 21 is nested beyond the maximum level of 3.

gadgetci · 2016-11-29T20:14:15Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+                                                               aff_insert_sql(RoomID, UserU, UserS, Aff));
+                                          false ->
+                                              {updated, _} = ejabberd_odbc:sql_query_t(
+                                                               aff_update_sql(RoomID, UserU, UserS, Aff))


According to Elvis:

Line 516 is too long: aff_update_sql(RoomID, UserU, UserS, Aff)).

gadgetci · 2016-11-29T20:14:16Z

test/ejabberd_tests/tests/muc_light_legacy_SUITE.erl

+                  true -> odbc;
+                  false -> mnesia
+              end,
+    ct:pal("Testing MUC Light with backend: ~p", [Backend]),


According to Elvis:

Remove the debug call to ct:pal/2 on line 133.

gadgetci · 2016-11-29T20:14:20Z

apps/ejabberd/src/mod_muc_light.erl

@@ -457,7 +464,7 @@ handle_disco_info_get(From, To, DiscoInfo) ->
 -spec handle_disco_items_get(From :: jid(), To :: jid(), DiscoItems :: #disco_items{},


According to Elvis:

The spec in line 464 uses a record, please define a type for the record and use that instead.

gadgetci · 2016-11-29T20:14:20Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+                         [{{UserU, UserS}, aff_db2atom(Aff)} || {UserU, UserS, Aff} <- AffUsersDB]),
+            case mod_muc_light_utils:change_aff_users(AffUsers, AffUsersChanges) of
+                {ok, NewAffUsers, AffUsersChanged, JoiningUsers, _LeavingUsers} ->
+                    case CheckFun(RoomUS, NewAffUsers) of


According to Elvis:

The expression on line 503 and column 21 is nested beyond the maximum level of 3.

gadgetci · 2016-11-29T20:14:22Z

apps/ejabberd/src/mod_muc_light.erl

@@ -336,7 +343,7 @@ process_iq_set(_Acc, #jid{ lserver = FromS } = From, To, #iq{} = IQ) ->
                true ->
                    {stop, {error, ?ERR_BAD_REQUEST}};
                false ->
-                    ok = ?BACKEND:set_blocking(jid:to_lus(From), Items),
+                    ok = ?BACKEND:set_blocking(jid:to_lus(From), MUCHost, Items),
                    ?CODEC:encode(Blocking, From, jid:to_lus(To),
                                  fun(_, _, Packet) -> put(encode_res, Packet) end),


According to Elvis:

The expression on line 348 and column 35 is nested beyond the maximum level of 3.

gadgetci · 2016-11-29T20:14:24Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+            {selected, _, [{RoomID}]} = ejabberd_odbc:sql_query_t(get_room_id_sql(RoomU, RoomS)),
+            lists:foreach(
+              fun({{UserU, UserS}, Aff}) ->
+                      {updated, _} = ejabberd_odbc:sql_query_t(aff_insert_sql(RoomID, UserU, UserS, Aff))


According to Elvis:

Line 325 is too long: {updated, _} = ejabberd_odbc:sql_query_t(aff_insert_sql(RoomID, UserU, UserS, Aff)).

gadgetci · 2016-11-29T20:14:25Z

test/ejabberd_tests/tests/mongoose_helper.erl

@@ -19,6 +21,13 @@

 -define(RPC(M,F,A), escalus_ejabberd:rpc(M, F, A)).


According to Elvis:

Missing space right "," on line 22

gadgetci · 2016-11-29T20:14:25Z

apps/ejabberd/src/mod_muc_light.erl

            create_room(From, FromUS, To, Create, OrigPacket);
-        false ->
+        true ->
            ?CODEC:encode_error(


According to Elvis:

Don't use macros (like CODEC on line 219) as module names.

gadgetci · 2016-11-29T20:14:26Z

apps/ejabberd/src/mod_muc_light.erl

+                    RoomsPerUser ->
+                        length(?BACKEND:get_user_rooms(FromUS, To#jid.lserver)) < RoomsPerUser
+                end,
+    if


According to Elvis:

Replace the 'if' expression on line 215 with a 'case' expression or function clauses.

gadgetci · 2016-11-30T11:06:33Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+            {selected, _, AffUsersDB} = ejabberd_odbc:sql_query(
+                                          MainHost, mod_muc_light_db_odbc_sql:select_affs(RoomID)),
+            AffUsers = [{{UserU, UserS}, aff_db2atom(Aff)} || {UserU, UserS, Aff} <- AffUsersDB],
+


According to Elvis:

Line 270 has 12 trailing whitespace characters.

gadgetci · 2016-11-30T11:06:34Z

apps/ejabberd/src/mod_muc_light.erl

            create_room(From, FromUS, To, Create, OrigPacket);
-        false ->
+        true ->
            ?CODEC:encode_error(


According to Elvis:

Remove the dynamic function call on line 219. Only modules that define callbacks should make dynamic calls.

gadgetci · 2016-11-30T11:06:35Z

test/ejabberd_tests/tests/mongoose_helper.erl

@@ -19,6 +21,13 @@

 -define(RPC(M,F,A), escalus_ejabberd:rpc(M, F, A)).


According to Elvis:

Missing space right "," on line 22

gadgetci · 2016-11-30T11:06:36Z

apps/ejabberd/src/mod_muc_light_db_odbc_sql.erl

+-export([select_blocking/2, select_blocking_cnt/3, insert_blocking/4,
+         delete_blocking/4, delete_blocking/2]).
+
+-define(esc(T), ejabberd_odbc:escape(T)).


According to Elvis:

Invalid macro name esc on line 37. Use UPPER_CASE.

gadgetci · 2016-11-30T11:06:38Z

test/ejabberd_tests/tests/mongoose_helper.erl

@@ -19,6 +21,13 @@

 -define(RPC(M,F,A), escalus_ejabberd:rpc(M, F, A)).


According to Elvis:

Missing space right "," on line 22

gadgetci · 2016-11-30T11:06:40Z

apps/ejabberd/src/mod_muc_light.erl

+                    RoomsPerUser ->
+                        length(?BACKEND:get_user_rooms(FromUS, To#jid.lserver)) < RoomsPerUser
+                end,
+    if


According to Elvis:

Replace the 'if' expression on line 215 with a 'case' expression or function clauses.

gadgetci · 2016-11-30T11:06:42Z

apps/ejabberd/src/mod_muc_light_utils.erl

@@ -152,7 +152,7 @@ filter_out_prevented(FromUS, {RoomU, MUCServer} = RoomUS, AffUsers) ->
                    end,
    if


According to Elvis:

Replace the 'if' expression on line 153 with a 'case' expression or function clauses.

gadgetci · 2016-11-30T11:06:43Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+                {selected, _, []} ->
+                    throw({aborted, Reason});
+                {selected, _, [_]} ->
+                    case NodeCandidate of


According to Elvis:

The expression on line 337 and column 21 is nested beyond the maximum level of 3.

gadgetci · 2016-11-30T11:06:45Z

apps/ejabberd/src/mod_muc_light.erl

            create_room(From, FromUS, To, Create, OrigPacket);
-        false ->
+        true ->
            ?CODEC:encode_error(


According to Elvis:

Don't use macros (like CODEC on line 219) as module names.

gadgetci · 2016-11-30T11:06:46Z

apps/ejabberd/src/mod_muc_light_db_odbc.erl

+    lists:map(
+      fun(RoomUS) ->
+              {RoomUS, modify_aff_users_transaction(
+                         RoomUS, [{UserUS, none}], fun(_,_) -> ok end, Version)}


According to Elvis:

Missing space right "," on line 383

gadgetci · 2016-11-30T11:06:48Z

apps/ejabberd/src/mod_muc_light_utils.erl

+        NotBlocked andalso RoomsBelowLimit ->
+            [AffUser | filter_out_loop(FromUS, MUCServer, BlockingQuery, RoomsPerUser, RAffUsers)];
+        true ->
+            filter_out_loop(FromUS, MUCServer, BlockingQuery, RoomsPerUser, RAffUsers)     


According to Elvis:

Line 183 has 5 trailing whitespace characters.

gadgetci · 2016-11-30T12:26:18Z

apps/ejabberd/src/mod_muc_light.erl

@@ -558,14 +565,15 @@ find_room_pos(_, [], _) -> {error, item_not_found}.
                      BlockingReq :: {get | set, #blocking{}}) ->
    {error, bad_request} | ok.
 handle_blocking(From, To, {get, #blocking{} = Blocking}) ->
-    ?CODEC:encode({get, Blocking#blocking{ items = ?BACKEND:get_blocking(jid:to_lus(From)) }},
+    BlockingItems = ?BACKEND:get_blocking(jid:to_lus(From), To#jid.lserver),


According to Elvis:

Remove the dynamic function call on line 568. Only modules that define callbacks should make dynamic calls.

gadgetci · 2016-11-30T12:26:19Z

apps/ejabberd/src/mod_muc_light_commands.erl

-get_user_rooms(UserJID) ->
-    ?BACKEND:get_user_rooms(jid:to_lus(UserJID)).
+get_user_rooms(UserJID, Domain) ->
+    ?BACKEND:get_user_rooms(jid:to_lus(UserJID), Domain).

 name_of_room_with_jid(RoomJID) ->
    case ?BACKEND:get_info(RoomJID) of


According to Elvis:

Remove the dynamic function call on line 186. Only modules that define callbacks should make dynamic calls.

gadgetci · 2016-11-30T12:26:19Z

apps/ejabberd/src/mod_muc_light.erl

                  From, jid:to_lus(To), fun ejabberd_router:route/3);
 handle_blocking(From, To, {set, #blocking{ items = Items }} = BlockingReq) ->
    case lists:any(fun({_, _, {WhoU, WhoS}}) -> WhoU =:= <<>> orelse WhoS =:= <<>> end, Items) of
        true ->
            {error, bad_request};
        false ->
-            ok = ?BACKEND:set_blocking(jid:to_lus(From), Items),
+            ok = ?BACKEND:set_blocking(jid:to_lus(From), To#jid.lserver, Items),


According to Elvis:

Don't use macros (like BACKEND on line 576) as module names.

gadgetci · 2016-11-30T12:26:20Z

apps/ejabberd/src/mod_muc_light.erl

@@ -304,7 +311,7 @@ add_rooms_to_roster(Acc, UserUS) ->
                                      children = [#xmlcdata{ content = RoomVersion }] }]
                       },
              [Item | Acc0]
-      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS)))).
+      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS, undefined)))).


According to Elvis:

Remove the dynamic function call on line 314. Only modules that define callbacks should make dynamic calls.

gadgetci · 2016-11-30T12:26:21Z

apps/ejabberd/src/mod_muc_light_utils.erl

+filter_out_loop(
+  FromUS, MUCServer, BlockingQuery, RoomsPerUser, [{UserUS, _} = AffUser | RAffUsers]) ->
+    NotBlocked = case (BlockingQuery == undefined orelse UserUS =:= FromUS) of
+                     false -> ?BACKEND:get_blocking(UserUS, MUCServer, BlockingQuery) == allow;


According to Elvis:

Remove the dynamic function call on line 172. Only modules that define callbacks should make dynamic calls.

gadgetci · 2016-11-30T12:26:22Z

apps/ejabberd/src/mod_muc_light_commands.erl

-get_user_rooms(UserJID) ->
-    ?BACKEND:get_user_rooms(jid:to_lus(UserJID)).
+get_user_rooms(UserJID, Domain) ->
+    ?BACKEND:get_user_rooms(jid:to_lus(UserJID), Domain).

 name_of_room_with_jid(RoomJID) ->
    case ?BACKEND:get_info(RoomJID) of


According to Elvis:

Don't use macros (like BACKEND on line 186) as module names.

michalwski · 2016-12-01T09:00:05Z

apps/ejabberd/src/mod_muc_light.erl

+                    infinity ->
+                        true;
+                    RoomsPerUser ->
+                        length(?BACKEND:get_user_rooms(FromUS, To#jid.lserver)) < RoomsPerUser


How difficult would it be to implement ?BACKEND:get_user_rooms_count? With count on the backend side?

Not difficult at all and actually I was considering it. Let's do it!

michalwski · 2016-12-01T09:00:56Z

apps/ejabberd/src/mod_muc_light.erl

    FromUS = jid:to_lus(From),
-    case RoomsPerUser == infinity orelse length(?BACKEND:get_user_rooms(FromUS)) < RoomsPerUser of
+    MayCreate = case get_opt(To#jid.lserver, rooms_per_user, ?DEFAULT_ROOMS_PER_USER) of


Could you move the whole case to a dedicated function with meaningful name?

Sure, why not.

michalwski · 2016-12-01T09:01:54Z

apps/ejabberd/src/mod_muc_light.erl

@@ -304,7 +311,7 @@ add_rooms_to_roster(Acc, UserUS) ->
                                      children = [#xmlcdata{ content = RoomVersion }] }]
                       },
              [Item | Acc0]
-      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS)))).
+      end, Acc, get_rooms_info(lists:sort(?BACKEND:get_user_rooms(UserUS, undefined)))).

 -spec process_iq_get(Acc :: any(), From :: #jid{}, To :: #jid{},


I agree with Elvis here.

michalwski · 2016-12-01T10:03:07Z

apps/ejabberd/src/mod_muc_light_utils.erl

-         (RoomsPerUser == infinity orelse length(?BACKEND:get_user_rooms(UserUS)) < RoomsPerUser) of
-        true -> [AffUser | filter_out_loop(FromUS, BlockingQuery, RoomsPerUser, RAffUsers)];
-        false -> filter_out_loop(FromUS, BlockingQuery, RoomsPerUser, RAffUsers)
+filter_out_loop(


How about following line split:

filter_out_loop(FromUS, MUCServer, BlockingQuery, RoomsPerUser, [{UserUS, _} = AffUser | RAffUsers])

Look the comment "source code" as Github renders it incorrectly.

gadgetci · 2016-12-02T18:32:03Z

apps/ejabberd/src/mod_muc_light.erl

-                    ?CODEC:encode_error({error, item_not_found}, From, To, OrigPacket,
-                                        fun ejabberd_router:route/3)
+                    mod_muc_light_codec_backend:encode_error(
+                      {error, item_not_found}, From, To, OrigPacket, fun ejabberd_router:route/3)


According to Elvis:

The expression on line 486 and column 70 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T18:32:04Z

apps/ejabberd/src/mod_muc_light.erl

-                    ok = ?BACKEND:set_blocking(jid:to_lus(From), Items),
-                    ?CODEC:encode(Blocking, From, jid:to_lus(To),
+                    ok = mod_muc_light_db_backend:set_blocking(jid:to_lus(From), MUCHost, Items),
+                    mod_muc_light_codec_backend:encode(Blocking, From, jid:to_lus(To),
                                  fun(_, _, Packet) -> put(encode_res, Packet) end),


According to Elvis:

The expression on line 349 and column 35 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T18:32:04Z

apps/ejabberd/src/mod_muc_light.erl

@@ -223,39 +224,40 @@ process_packet(From, To, {ok, {_, #blocking{}} = Blocking}, OrigPacket) ->
                ok ->
                    ok;
                Error ->
-                    ?CODEC:encode_error(Error, From, To, OrigPacket,
+                    mod_muc_light_codec_backend:encode_error(Error, From, To, OrigPacket,
                                                     fun ejabberd_router:route/3)


According to Elvis:

The expression on line 228 and column 54 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T18:32:05Z

apps/ejabberd/src/mod_muc_light.erl

        Rooms ->
            RoomsInfo = get_rooms_info(lists:sort(Rooms)),
            RoomsPerPage = get_opt(To#jid.lserver, rooms_per_page, ?DEFAULT_ROOMS_PER_PAGE),
            case apply_rsm(RoomsInfo, length(RoomsInfo),
                           page_service_limit(DiscoItems0#disco_items.rsm, RoomsPerPage)) of
                {ok, RoomsInfoSlice, RSMOut} ->
                    DiscoItems = DiscoItems0#disco_items{ rooms = RoomsInfoSlice, rsm = RSMOut },
-                    ?CODEC:encode({get, DiscoItems}, From, jid:to_lus(To),
+                    mod_muc_light_codec_backend:encode({get, DiscoItems}, From, jid:to_lus(To),
                                  fun ejabberd_router:route/3);


According to Elvis:

The expression on line 483 and column 35 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T18:32:06Z

apps/ejabberd/src/mod_muc_light.erl

 process_iq_set(_Acc, #jid{ lserver = FromS } = From, To, #iq{} = IQ) ->
    MUCHost = gen_mod:get_module_opt_host(FromS, ?MODULE, ?DEFAULT_HOST),
-    case {?CODEC:decode(From, To, IQ), get_opt(MUCHost, blocking, ?DEFAULT_BLOCKING)} of
+    case {mod_muc_light_codec_backend:decode(From, To, IQ),
+          get_opt(MUCHost, blocking, ?DEFAULT_BLOCKING)} of
        {{ok, {set, #blocking{ items = Items }} = Blocking}, true} ->
            case lists:any(fun({_, _, {WhoU, WhoS}}) ->


According to Elvis:

The expression on line 341 and column 28 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T19:02:20Z

apps/ejabberd/src/mod_muc_light.erl

-
+                    mod_muc_light_codec_backend:encode_error({error, item_not_found},
+                                                             From, To, OrigPacket,
+                                                             fun ejabberd_router:route/3)


According to Elvis:

The expression on line 486 and column 62 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T19:02:21Z

apps/ejabberd/src/mod_muc_light.erl

-                    ?CODEC:encode(Blocking, From, jid:to_lus(To),
-                                  fun(_, _, Packet) -> put(encode_res, Packet) end),
+                    ok = mod_muc_light_db_backend:set_blocking(jid:to_lus(From), MUCHost, Items),
+                    RouteFun = fun(_, _, Packet) -> put(encode_res, Packet) end,


According to Elvis:

The expression on line 347 and column 32 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T19:02:21Z

apps/ejabberd/src/mod_muc_light.erl

-                    ?CODEC:encode_error(Error, From, To, OrigPacket,
-                                                     fun ejabberd_router:route/3)
+                    mod_muc_light_codec_backend:encode_error(Error, From, To, OrigPacket,
+                                                             fun ejabberd_router:route/3)


According to Elvis:

The expression on line 228 and column 62 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T19:02:22Z

apps/ejabberd/src/mod_muc_light.erl

-            case lists:any(fun({_, _, {WhoU, WhoS}}) ->
-                                   WhoU =:= <<>> orelse WhoS =:= <<>>
-                           end, Items) of
+            case lists:any(fun({_, _, {WhoU, WhoS}}) -> WhoU =:= <<>> orelse WhoS =:= <<>> end,


According to Elvis:

The expression on line 341 and column 28 is nested beyond the maximum level of 3.

gadgetci · 2016-12-02T19:02:23Z

apps/ejabberd/src/mod_muc_light.erl

        Rooms ->
            RoomsInfo = get_rooms_info(lists:sort(Rooms)),
            RoomsPerPage = get_opt(To#jid.lserver, rooms_per_page, ?DEFAULT_ROOMS_PER_PAGE),
            case apply_rsm(RoomsInfo, length(RoomsInfo),
                           page_service_limit(DiscoItems0#disco_items.rsm, RoomsPerPage)) of
                {ok, RoomsInfoSlice, RSMOut} ->
                    DiscoItems = DiscoItems0#disco_items{ rooms = RoomsInfoSlice, rsm = RSMOut },
-                    ?CODEC:encode({get, DiscoItems}, From, jid:to_lus(To),
+                    mod_muc_light_codec_backend:encode({get, DiscoItems}, From, jid:to_lus(To),
                                  fun ejabberd_router:route/3);


According to Elvis:

The expression on line 482 and column 35 is nested beyond the maximum level of 3.

michalwski · 2016-12-05T07:44:51Z

Good job! I'll merge it today.

fenek added 5 commits November 25, 2016 14:40

Fix MUC Light blocking specs

9ec02f9

Add MUC Light ODBC backend

221523b

Add PgSQL MUC Light schema

8718c42

Fix affiliations get in MUC Light ODBC

c79f92d

Fix & optimise MUC Light DB user (room-less) functions

5b1a842

fenek added the WIP 🚧 label Nov 29, 2016

gadgetci reviewed Nov 29, 2016

View reviewed changes

Refactor mod_muc_light_db_odbc

e2861bd

gadgetci reviewed Nov 30, 2016

View reviewed changes

fenek added waiting-for-review and removed WIP 🚧 labels Nov 30, 2016

michalwski reviewed Dec 1, 2016

View reviewed changes

More happiness for reviewers and Elvis in MUC Light

6b30fcc

gadgetci reviewed Dec 2, 2016

View reviewed changes

Resolve current Elvis' complaints about MUC Light

382fa14

fenek force-pushed the 16033-muc-light-odbc branch from 6ee2a47 to 382fa14 Compare December 2, 2016 19:53

[skip ci] Update MUC Light doc

0821777

michalwski added ready and removed waiting-for-review labels Dec 5, 2016

michalwski merged commit f7ddaba into master Dec 5, 2016

michalwski deleted the 16033-muc-light-odbc branch December 5, 2016 08:33

This was referenced Jan 20, 2017

MongooseIM 2.0.1 #1160

Merged

MongooseIM 2.0.1 #1164

Merged

		@@ -457,7 +464,7 @@ handle_disco_info_get(From, To, DiscoInfo) ->
		-spec handle_disco_items_get(From :: jid(), To :: jid(), DiscoItems :: #disco_items{},

		@@ -19,6 +21,13 @@

		-define(RPC(M,F,A), escalus_ejabberd:rpc(M, F, A)).

		@@ -152,7 +152,7 @@ filter_out_prevented(FromUS, {RoomU, MUCServer} = RoomUS, AffUsers) ->
		end,
		if

MUC Light ODBC #1093

MUC Light ODBC #1093

Conversation

fenek commented Nov 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

michalwski commented Dec 5, 2016